[ET-VK] Fix VMA assertion caused by bool return type truncation#18721
Open
pytorchbot wants to merge 1 commit intorelease/1.2from
Open
[ET-VK] Fix VMA assertion caused by bool return type truncation#18721pytorchbot wants to merge 1 commit intorelease/1.2from
pytorchbot wants to merge 1 commit intorelease/1.2from
Conversation
This was referenced Apr 6, 2026
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18721
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 1 Unrelated FailureAs of commit 918b1bb with merge base 8c0a60b ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The
test_host_cached_availablefunction in Allocator.cpp was introduced inD95836687 with a
boolreturn type, but its return statements returnVmaAllocationCreateFlagsvalues (VMA_ALLOCATION_CREATE_HOST_ACCESS_RANDOM_BIT= 0x1000 and
VMA_ALLOCATION_CREATE_HOST_ACCESS_SEQUENTIAL_WRITE_BIT= 0x800).The
boolreturn type truncates both to1, which equalsVMA_ALLOCATION_CREATE_DEDICATED_MEMORY_BIT— not a host access flag.This caused VMA to assert when allocating host-mapped staging buffers because
the allocation had
MAPPED_BIT+AUTO_PREFER_HOSTbut no host access flag.Fix the return type from
booltoVmaAllocationCreateFlagsso the correctflag values are preserved.
Differential Revision: D96151798